RFR: 8339883: Open source several AWT/2D related tests [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Sep 13 09:37:05 UTC 2024


On Thu, 12 Sep 2024 22:46:51 GMT, Phil Race <prr at openjdk.org> wrote:

>> This open sources a few AWT/2D regression tests.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8339883

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/GraphicsConfiguration/NonDefaultGC.java line 31:

> 29:  * of windows with RGB stripes in according to the number of the
> 30:  * GraphicsConfigurations for each screen. It also displays the size of
> 31:  * the screen and the GraphicsConfiguration.toString().

Better to align the sentences after @summary tag words so that @tags can be on one column and other sentences do not encroach, similar to test/jdk/sun/java2d/pipe/DrawImageBgTest.java in this PR

test/jdk/java/awt/GraphicsConfiguration/Position.java line 31:

> 29:  * The togglebutton shows and hides an empty frame on the second monitor. The
> 30:  * frame should be positioned at 0, 0 and is shown and hidden by clicking the
> 31:  * toggleButton.

same here

-------------

PR Review: https://git.openjdk.org/jdk/pull/20977#pullrequestreview-2302625489
PR Review Comment: https://git.openjdk.org/jdk/pull/20977#discussion_r1758527331
PR Review Comment: https://git.openjdk.org/jdk/pull/20977#discussion_r1758532670


More information about the client-libs-dev mailing list