RFR: JDK-8340210 : Add positionTestUI() to PassFailJFrame.Builder [v2]

[Alexey Ivanov]

On Mon, 16 Sep 2024 21:31:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed errorenous check
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1277:
> 
>> 1275:                                                 + "nor a list of test windows "
>> 1276:                                                 + "has been provided");
>> 1277:             }
> 
> @aivanov-jdk Running into exception when this check is added here. I believe Builder's windowListCreator and testWindows are not assigned yet at this stage.
>   
> And since this check is already in-place here: [validate()](https://github.com/openjdk/jdk/blob/418bb42b95b177f5f31f756054d0dd83740c6686/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1475C1-L1479C18), I'm removing it from positionTestUI().

The condition should've been `&&`: the error message is correct, the exception was supposed to be thrown if both `windowListCreator` and `testWindows` is null. The condition with `||` is always `true`.

Yet I agree to remove this condition from here as it enforces the order of calls, which is not strictly required, even though it would common to add a window creator before setting positioning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21023#discussion_r1762800438