RFR: 8339984: Open source AWT MenuItem related tests [v3]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 18 10:12:09 UTC 2024


On Wed, 18 Sep 2024 10:07:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I gave a try to get PassFailFrame position but some error occured and then hard coded. I agree hard-coding is not a best solution and thanks for suggesting the other way around. A bit of correction in setting the testFrame location, y co-ordinate should be firstFrame.getY() + firstFrame.getHeight() + 8 else the gap is more between firstFrame and testFrame.
>
> Yes, it should be `getHeight()`. I initially used `getSize().height` and then changed it to `getHeight()` and must have selected the wrong suggestion in IDE and ended up with `getWidth()` instead.

Actually, I thought `.positionTestWindow` would be called for the first window automatically, then you can position other windows based on the assigned location. Eventually, it's not called at all if a list of windows is created.

I'll submit a bug for it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764786778


More information about the client-libs-dev mailing list