RFR: 8339984: Open source AWT MenuItem related tests [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Sep 18 10:51:50 UTC 2024
On Wed, 18 Sep 2024 10:33:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> What about Linux? Solaris isn't supported by JDK any more.
Tested on linux. Menu's font are large and on Windows it is normal size.
> Here, you may want to clarify where it's referring to a menu (item) on the menu bar and where the instructions refer to popup menu shown after activating the item on the menu bar. Just to make the instructions clearer.
It is about the menu present on menu bar. Modified the test instructions.
> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 51:
>
>> 49: LotsOfMenuItemsTest obj = new LotsOfMenuItemsTest();
>> 50: String INSTRUCTIONS = """
>> 51: This test creates lots of frames with menubars.
>
> Suggestion:
>
> This test creates lots of frames with menu bars.
>
> It's usually spelt with a space.
Ok.. updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764836399
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764834778
More information about the client-libs-dev
mailing list