RFR: 8339984: Open source AWT MenuItem related tests [v4]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 18 11:16:15 UTC 2024


On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT MenuItem related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test instruction update

test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 83:

> 81:     }
> 82: 
> 83:     public void componentShown(ComponentEvent e) {

Suggestion:

    @Override
    public void componentShown(ComponentEvent e) {

Please add `@Override` annotation where applicable. It makes it explicit that a method implements an interface or overrides a method of a superclass.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764865262


More information about the client-libs-dev mailing list