RFR: 8339984: Open source AWT MenuItem related tests [v3]

Alexey Ivanov aivanov at openjdk.org
Wed Sep 18 12:23:15 UTC 2024


On Wed, 18 Sep 2024 12:06:31 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>>>What about macOS? The test can be run there.
>> 
>> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?
>
>>I'm for replacing Solaris with Linux. There's no way a test would be run on Solaris using the most recent version of Java.
> When backporting, the text could be updated to “on Linux and Solaris”.
> What about macOS? The test can be run there.
> 
> Replaced Solaris with Linux and updated the test instruction for MacOS as well.

> > What about macOS? The test can be run there.
> 
> On macOS, it is of the normal font like windows. Should I update the instructions for macOS as well?

Looks like the test isn't applicable to macOS at all. AWT menu bar integrates with the macOS native menu bar at the top, the application can't seem to control how menu is rendered there, so both the item on the menu bar and items in the popup menu remain of regular font size.

On Windows, the menu items in the popup menu use the large font.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764954422


More information about the client-libs-dev mailing list