RFR: 8340271: Open source several AWT Robot tests [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Thu Sep 19 09:10:37 UTC 2024
On Thu, 19 Sep 2024 05:59:21 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Opensource few Robot tests
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Formatting
test/jdk/java/awt/Robot/CreateScreenCapture.java line 43:
> 41: public class CreateScreenCapture {
> 42:
> 43: static Robot robot;
`robot` var also can be moved inside main.
test/jdk/java/awt/Robot/CreateScreenCapture.java line 79:
> 77:
> 78: private static void log(String messageIn) {
> 79: messageText.append( messageIn + "\n");
Suggestion:
messageText.append(messageIn + "\n");
test/jdk/java/awt/Robot/RobotScrollTest.java line 47:
> 45: private static final String INSTRUCTIONS = """
> 46: 0. DON'T TOUCH ANYTHING!
> 47: 1. This test is for Windown and Linux only.
Suggestion:
1. This test is for Windows and Linux only.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766463911
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766464170
PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766464530
More information about the client-libs-dev
mailing list