RFR: 8339906: Open source several AWT focus tests - series 4 [v4]

[Abhishek Kumar]

On Fri, 20 Sep 2024 05:13:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/java/awt/Focus/AltTabEventsTest.java line 80:
>> 
>>> 78:                 .rows((int) INSTRUCTIONS.lines().count() + 5)
>>> 79:                 .columns(35)
>>> 80:                 .testUI(AltTabEventsTest::createTestUI)
>> 
>> can be changed to `new Test();` and thus leading to remove the `createTestUI()` method.
>
> ok

Looks like you missed this.

>> test/jdk/java/awt/Focus/AltTabEventsTest.java line 104:
>> 
>>> 102:         WindowAdapter wa = new WindowAdapter() {
>>> 103:                 public void windowActivated(WindowEvent e) {
>>> 104:                     println(e.toString());
>> 
>> can be replaced with `PassFailJFrame.log` everywhere. Anyways there is a repetition of `println`.
>> Suggestion:
>> 
>>                     PassFailJFrame.log(e.toString());
>
> it will be same..

`println` method can be removed if `PassFailJFrame.log` is used directly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767997395
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1767998311