RFR: 8340084: Open source AWT Frame related tests [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Sep 20 07:47:36 UTC 2024
On Thu, 19 Sep 2024 05:21:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment fix
test/jdk/java/awt/Frame/DefaultLocationTest.java line 59:
> 57: EventQueue.invokeAndWait(() -> {
> 58: if (f != null) {
> 59: f.dispose();
We add "f" to PassFailJFrame through `addTestWIndow` so I would assume `awaitAndCheck` should dispose off the frame when we press Pass/Fail, no need to do it explicitly..
test/jdk/java/awt/Frame/FrameLayoutTest.java line 33:
> 31: * @library /java/awt/regtesthelpers
> 32: * @requires (os.family == "windows")
> 33: * @build PassFailJFrame
guess @library @build placement should be together, although not mandatory I presume..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768063691
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768140237
More information about the client-libs-dev
mailing list