RFR: 8340084: Open source AWT Frame related tests [v3]

Andrey Turbanov aturbanov at openjdk.org
Fri Sep 20 19:38:35 UTC 2024


On Fri, 20 Sep 2024 08:04:30 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Few AWT Frame related tests are converted from applet to manual and moved to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comment update

test/jdk/java/awt/Frame/FrameLayoutTest.java line 65:

> 63:         f.add(new Button("East"),BorderLayout.EAST);
> 64:         f.add(new Button("West"),BorderLayout.WEST);
> 65:         f.add(new Button("Cent"),BorderLayout.CENTER);

Suggestion:

        f.add(new Button("North"), BorderLayout.NORTH);
        f.add(new Button("South"), BorderLayout.SOUTH);
        f.add(new Button("East"), BorderLayout.EAST);
        f.add(new Button("West"), BorderLayout.WEST);
        f.add(new Button("Cent"), BorderLayout.CENTER);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1769169427


More information about the client-libs-dev mailing list