RFR: 8337287: Update image in javax.swing.text.Document.insert
Alexey Ivanov
aivanov at openjdk.org
Sun Sep 22 14:47:14 UTC 2024
On Mon, 29 Jul 2024 13:43:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> This changeset updates the image in the documentation for the `Document.insert` method. The image in `Document.remove` was updated by [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>
> Now the illustration of inserting looks similar to removing. The new image is in SVG format.
>
> For reference:
>
> - [`Document.insert` in JDK 22](https://docs.oracle.com/en/java/javase/22/docs/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet));
> - [Updated docs for JDK 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>
> As in the case with `remove`, I marked up to classes and members with {@code}.
> > > Just curious why the chars are not in the middle of the boxes?
> >
> > The text is positioned in the middle of the box -0.5 pixels.
>
> Moving the text position by 0.5 seems to help, and the values become equal: 7 on either side.
>
> This needs to be done for the image in `remove` too, so I'd rather do that separately, at a later time.
Submitted [JDK-8340580](https://bugs.openjdk.org/browse/JDK-8340580): *Characters in Document diagrams not in the middle*.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20376#issuecomment-2366822283
More information about the client-libs-dev
mailing list