RFR: 7188058: Background of TextComponents are not changing colors to the default disabled color when set to uneditable [v5]

Alexey Ivanov aivanov at openjdk.org
Mon Sep 23 13:33:38 UTC 2024


On Fri, 23 Aug 2024 05:24:16 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix import
>
> src/java.desktop/share/classes/java/awt/TextArea.java line 610:
> 
>> 608: 
>> 609:     @Override
>> 610:     public synchronized void setEditable(boolean b) {
> 
> `setEditable` method is overridden in both `TextArea` and `TextField` class and method implementation is same. Since both of them are  inherited from `TextComponent` class, could we move the code to `TextComponent's setEditable` method and remove them from respective classes?

This is a good suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1771426903


More information about the client-libs-dev mailing list