RFR: 8339935: Open source several AWT focus tests - series 5

Phil Race prr at openjdk.org
Mon Sep 23 18:06:37 UTC 2024


On Fri, 20 Sep 2024 03:23:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Opensource few AWT focus tests

Changes requested by prr (Reviewer).

test/jdk/java/awt/Focus/LightweightPopupTest.java line 27:

> 25:  * @test
> 26:  * @bug 4472032
> 27:  * @summary Switching between lightweight menus by holizontal arrow key works incorrect

holizontal -> horizontal

test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 27:

> 25:  * @test
> 26:  * @bug 4396407
> 27:  * @summary Tests that after proxied window were hidden focus is being restored correctly

... after a proxied window is hidden ...

test/jdk/java/awt/Focus/ProxiedWindowHideTest.java line 43:

> 41: 
> 42:     private static final String INSTRUCTIONS = """
> 43:            You will see JFrame with title 'TEST'.

looks to me like the title is actually "ProxiedWindowHideTest frame".
A tester might decide to fail the test because of this.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21103#pullrequestreview-2322970675
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771870228
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771874098
PR Review Comment: https://git.openjdk.org/jdk/pull/21103#discussion_r1771873321


More information about the client-libs-dev mailing list