RFR: 8339982: Open source several AWT Mouse tests - Batch 2

[Prasanta Sadhukhan]

On Mon, 23 Sep 2024 06:40:55 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source these AWT Mouse and GraphicsEnvironment tests:
> 
> java/awt/MouseClickCount/MouseClickCount.java
> java/awt/MouseDragEnterExitTest/MouseDragEnterExitTest.java
> java/awt/MouseDragTest/MouseDragTest.java
> java/awt/OpenWinDoubleClickTest/OpenWinDoubleClickTest.java
> java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java

test/jdk/java/awt/GraphicsEnvironment/DefaultScreenDeviceTest.java line 43:

> 41:  *          returning first screen
> 42:  * @requires (os.family == "windows")
> 43:  * @library /open/test/jdk/java/awt/regtesthelpers

Seems like you have not tested these tests after opensourcing...Please adjust to correct path for all the tests..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 98:

> 96: 
> 97:     public void mousePressed(MouseEvent e) {
> 98:     }

I guess if you use MouseAdapter instead of MouseListener, then you only have to provide implementation for the method you need, not for all..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 128:

> 126:         if (e.getID() == MouseEvent.MOUSE_EXITED)
> 127:             type = "MOUSE_EXITED";
> 128: 

MOUSE_ENTERED is used twice...Also, it seems you are only printing MouseExit/Enter so other types can be deleted..

test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 168:

> 166:     public void mouseClicked(MouseEvent e) {
> 167:     }
> 168: 

same here...MouseAdapter...

test/jdk/java/awt/Mouse/OpenWinDoubleClickTest.java line 38:

> 36:  * @library /open/test/jdk/java/awt/regtesthelpers
> 37:  * @build PassFailJFrame
> 38:  * @run main/manual OpenWinDoubleClickTest

Guess we decided to rename this test...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772472012
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772475894
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772476755
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772477852
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772472446