RFR: 8340785: Update description of PassFailJFrame and samples

Phil Race prr at openjdk.org
Tue Sep 24 18:10:35 UTC 2024


On Tue, 24 Sep 2024 15:51:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> I re-worked the entire description of `PassFailJFrame`:
> 
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
> 
> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
> Use method references instead of lambdas in samples.
> Document required jtreg tags to use `PassFailJFrame`.
> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
> 
> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
> 
> As in #21145, the generated javadoc [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html) could be easier to read and review.
> 
> The current version of the generated docs contains changes from #21145 and this PR. The PRs can be integrated independently.

Marked as reviewed by prr (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 85:

> 83:  * <i>Pass</i> / <i>Fail</i> buttons. The framework automatically
> 84:  * creates a frame to display the instructions, provides buttons
> 85:  * to select the test result, handles test timeout.

"and handles"

-------------

PR Review: https://git.openjdk.org/jdk/pull/21162#pullrequestreview-2325919120
PR Review Comment: https://git.openjdk.org/jdk/pull/21162#discussion_r1773750384


More information about the client-libs-dev mailing list