RFR: 8340605: Open source several AWT PopupMenu tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Wed Sep 25 07:42:03 UTC 2024


On Wed, 25 Sep 2024 07:26:12 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove blank line
>
> test/jdk/java/awt/PopupMenu/PopupLeadingSeparatorTest.java line 48:
> 
>> 46:                 Press mouse button on the frame. Popup menu without leading
>> 47:                 separator should appear.
>> 48:                 If a PopupMenu behaves same, press Pass, else press Fail.
> 
> Suggestion:
> 
>                 If a PopupMenu behaves same press Pass, else press Fail.

seems correct to me.

> test/jdk/java/awt/PopupMenu/PopupOnButton.java line 48:
> 
>> 46:                 Right-click on the button.
>> 47:                 Popup Menu should appear and behave fine.
>> 48:                 If a PopupMenu appears, press Pass, else press Fail.
> 
> Suggestion:
> 
>                 If a PopupMenu appears press Pass, else press Fail.

same here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774702878
PR Review Comment: https://git.openjdk.org/jdk/pull/21151#discussion_r1774703670


More information about the client-libs-dev mailing list