RFR: 8339879: Open some dialog swing tests

Tejesh R tr at openjdk.org
Thu Sep 26 07:02:39 UTC 2024


On Thu, 26 Sep 2024 01:11:03 GMT, Alisen Chung <achung at openjdk.org> wrote:

> First set of dialog swing tests to open during fall 2024 test sprint

test/jdk/java/awt/Dialog/DialogInitialResizability.java line 35:

> 33:  * @summary Checks that with resizable set to false before show()
> 34:  *          dialog can not be resized.
> 35:  * @library jdk/java/awt/regtesthelpers

Suggestion:

 * @library /java/awt/regtesthelpers

Other places too.

test/jdk/java/awt/Dialog/DialogInitialResizability.java line 42:

> 40: public class DialogInitialResizability {
> 41:     static String instructions = """
> 42:                     Steps to try to reproduce the problem:

Suggestion:

                    Steps to try to reproduce the problem:

Can remove this line.

test/jdk/java/awt/Dialog/ShownModalDialogSerializationTest.java line 66:

> 64:     static void deleteTestUI() {
> 65:         if (dialog != null) {
> 66:             dialog.setVisible(false);

Can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776483877
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776487151
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1776489614


More information about the client-libs-dev mailing list