RFR: 8340354: Open source AWT desktop properties and print related tests

[Andrey Turbanov]

On Thu, 26 Sep 2024 05:47:33 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> AWT Desktop properties and printer related tests are converted from applet to manual and moved to open.

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 195:

> 193:         menu3.setEnabled(false);
> 194:         menu4.setEnabled(false);
> 195:         MenuItem itemPrinter  = new MenuItem("Print to Printer...");

Suggestion:

        MenuItem itemPrinter = new MenuItem("Print to Printer...");

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 196:

> 194:         menu4.setEnabled(false);
> 195:         MenuItem itemPrinter  = new MenuItem("Print to Printer...");
> 196:         MenuItem itemScreen  = new MenuItem("Print to Screen...");

Suggestion:

        MenuItem itemScreen = new MenuItem("Print to Screen...");

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 214:

> 212:     {
> 213:         Enumeration propNames = props.propertyNames();
> 214:         while(propNames.hasMoreElements()) {

Suggestion:

        while (propNames.hasMoreElements()) {

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 229:

> 227:             PrintJob pj = getToolkit().getPrintJob(
> 228:                 MainFrame.this, "Print test!", props);
> 229:             if( pj == null ) {

Suggestion:

            if (pj == null) {

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 274:

> 272:     class ActionPrintToScreen implements ActionListener {
> 273:         public void actionPerformed(ActionEvent ev) {
> 274:             PrintFrame  printFrame = new PrintFrame( MainFrame.this );

Suggestion:

            PrintFrame printFrame = new PrintFrame( MainFrame.this );

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 312:

> 310:         String label;
> 311:         int     width = 100;
> 312:         int     height = 30;

Suggestion:

        int width = 100;
        int height = 30;

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 332:

> 330:         public Dimension getPreferredSize()
> 331:         {
> 332:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 364:

> 362:         public Dimension getPreferredSize()
> 363:         {
> 364:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintCompatibilityTest.java line 416:

> 414:             // component at the top of the z-order, that should print
> 415:             // _below_ the native guys to match the screen...
> 416:             add(new LWButton("LWButton"),0);

Suggestion:

            add(new LWButton("LWButton"), 0);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 227:

> 225:                 new MenuItem("Print to Printer in Background");
> 226:         itemBackground.setActionCommand("none");
> 227:         MenuItem itemScreen  = new MenuItem("Print to Screen...");

Suggestion:

        MenuItem itemScreen = new MenuItem("Print to Screen...");

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 270:

> 268:             PrintJob pj = getToolkit().getPrintJob(
> 269:                     MainFrame.this, "Print test!", jobAttributes, pageAttributes);
> 270:             if( pj == null ) return;

Suggestion:

            if (pj == null) return;

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 312:

> 310:     class ActionPrintToScreen implements ActionListener {
> 311:         public void actionPerformed(ActionEvent ev) {
> 312:             PrintFrame  printFrame = new PrintFrame( MainFrame.this );

Suggestion:

            PrintFrame printFrame = new PrintFrame( MainFrame.this );

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 350:

> 348:         String label;
> 349:         int     width = 100;
> 350:         int     height = 30;

Suggestion:

        int width = 100;
        int height = 30;

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 370:

> 368:         public Dimension getPreferredSize()
> 369:         {
> 370:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 402:

> 400:         public Dimension getPreferredSize()
> 401:         {
> 402:             return new Dimension(width,height);

Suggestion:

            return new Dimension(width, height);

test/jdk/java/awt/PrintJob/PrintComponentTest.java line 454:

> 452:             // component at the top of the z-order, that should print
> 453:             // _below_ the native guys to match the screen...
> 454:             add(new LWButton("LWButton"),0);

Suggestion:

            add(new LWButton("LWButton"), 0);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777050594
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777050882
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777052492
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777052858
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053052
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053426
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053649
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777053854
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777054089
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777045638
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777046211
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777046623
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777047330
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777048754
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777049214
PR Review Comment: https://git.openjdk.org/jdk/pull/21197#discussion_r1777049932