RFR: 8339475: Check return value of pthread_create in jdk coding [v2]

Matthias Baesken mbaesken at openjdk.org
Thu Sep 26 14:34:38 UTC 2024


On Thu, 26 Sep 2024 07:10:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove rc

Interesting, the errno is not even set on macOS according to the man page, at least for pthread_detach
https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/pthread_detach.3.html
"Note that the function does not change the value of errno, as it did for some drafts of the standard. "
So better print the return code there in the error case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21182#issuecomment-2377148133


More information about the client-libs-dev mailing list