RFR: 8339879: Open some dialog swing tests [v2]
Harshitha Onkar
honkar at openjdk.org
Fri Sep 27 00:04:39 UTC 2024
On Thu, 26 Sep 2024 16:04:31 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> First set of dialog swing tests to open during fall 2024 test sprint
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> update jtreg
LGTM other than the minor comments
test/jdk/java/awt/Dialog/DialogInitialResizability.java line 96:
> 94: }
> 95: }
> 96: }
Missing EOF newline
test/jdk/java/awt/Dialog/NestedDialogTest.java line 45:
> 43: * @test
> 44: * @bug 4110094 4178930 4178390
> 45: * @summary Test: Rewrite of Win32 modal dialogs
Suggestion:
* @summary Test: Rewrite of Win modal dialogs
test/jdk/java/awt/Dialog/NestedDialogTest.java line 312:
> 310: super.dispose();
> 311: }
> 312: }
missing EOF newline
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21196#pullrequestreview-2332532470
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861509
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861019
PR Review Comment: https://git.openjdk.org/jdk/pull/21196#discussion_r1777861225
More information about the client-libs-dev
mailing list