RFR: 8317116: Provide layouts for multiple test UI in PassFailJFrame [v2]

Alexander Zvegintsev azvegint at openjdk.org
Fri Sep 27 14:27:35 UTC 2024


On Fri, 27 Sep 2024 14:19:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/regtesthelpers/WindowLayouts.java line 133:
>> 
>>> 131:     public static void bottomOneRowCentered(final List<Window> windows,
>>> 132:                                             final PassFailJFrame.InstructionUI instructionUI) {
>>> 133:         layoutColumn(getScreenCenter().x
>> 
>> Suggestion:
>> 
>>         layoutRow(getScreenCenter().x
>> 
>> 
>> typo.
>
> Let me check… All the samples look good, however, this looks like a typo.

I tried this

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21210/head:pull/21210
$ git checkout pull/21210


And the BottomOneRowCentered example looks like following to me: 
![image](https://github.com/user-attachments/assets/c455c8f1-91b8-4664-b445-4598a835cedb)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778713508


More information about the client-libs-dev mailing list