RFR: 8317116: Provide layouts for multiple test UI in PassFailJFrame [v2]

Alexey Ivanov aivanov at openjdk.org
Fri Sep 27 15:20:38 UTC 2024


On Fri, 27 Sep 2024 14:58:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> No, not directly.
>> 
>> But you can combine it with explicit call to `WindowLayouts`:
>> 
>> 
>> .positionTestUI((testWindows, instructionUI) -> {
>>     instructionUI.setLocation(200, 200);
>>     WindowLayouts.rightOneRow(testWindows, instructionUI);
>> })
>> 
>> 
>> So, this (rare) scenario still doesn't require you to reimplement everything.
>
> Oh, I hadn't paid attention to the fact that these methods are public. I guess it is a good solution to my request.

I like the updated version much better that what I had initially. It's really *flexible* now. One can combine different layouts on sublists to achieve more complex layouts. Yet I am still to play around with it. Anyway more complex layouts are out of scope for this PR.

Thank you @azvegint! It is your usage in #21180 that made me realise I had overcomplicated the code for laying out windows.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21207#discussion_r1778791631


More information about the client-libs-dev mailing list