RFR: 8339475: Clean up return code handling for pthread calls in library coding [v3]

[Florian Weimer]

On Thu, 26 Sep 2024 14:44:53 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> It has been discussed that checking the return value of pthread_create should be done.
>> See the discussion here https://github.com/openjdk/jdk/pull/20812 about the splashscreen coding .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   some macOS cleanup

src/java.base/macosx/native/libjli/java_md_macosx.m line 315:

> 313:     rc = pthread_create(&main_thr, NULL, &apple_main, &args);
> 314:     if (rc != 0) {
> 315:         JLI_ReportErrorMessageSys("Could not create main thread, return code: %s\n", rc);

This looks buggy, so I filed: https://bugs.openjdk.org/browse/JDK-8341135

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1779461874