RFR: 8340719: Open source AWT List tests [v2]

[Prasanta Sadhukhan]

On Mon, 30 Sep 2024 11:52:22 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Formatting
>
> test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 49:
> 
>> 47: import java.awt.event.MouseAdapter;
>> 48: import java.awt.event.MouseMotionAdapter;
>> 49: import java.awt.event.MouseEvent;
> 
> Suggestion:
> 
> import java.awt.event.MouseEvent;
> import java.awt.event.MouseMotionAdapter;

ok

> test/jdk/java/awt/List/HandlingKeyEventIfMousePressedTest.java line 73:
> 
>> 71:             // key pressing when the mouse is kept in the 'pressed' state
>> 72:             robot.keyPress(KeyEvent.VK_DOWN);
>> 73:             robot.keyRelease(KeyEvent.VK_DOWN);
> 
> Test summary says about "SPACE, UP and DOWN" keys but the test checks only for "DOWN" key... should it extend for other keys as well?

Original test is similar so have not changed.

> test/jdk/java/awt/List/ListActionEventTest.java line 56:
> 
>> 54:                 .title("ListActionEventTest Instructions")
>> 55:                 .instructions(INSTRUCTIONS)
>> 56:                 .rows((int) INSTRUCTIONS.lines().count() + 2)
> 
> may be removed.

not mandatory...

> test/jdk/java/awt/List/MultiSelectionListHorizScrollbar.java line 41:
> 
>> 39:     private static final String INSTRUCTIONS = """
>> 40:          Resize the frame so that the lists are not wide enough to fully display the lines of text they contain.
>> 41:          Once the lists are in this state, press pass if both lists display an horizontal scrollbar. Otherwise press fail.""";
> 
> Plz limit it to 80

ok

> test/jdk/java/awt/List/RepaintAfterResize.java line 63:
> 
>> 61:         frame.setLayout (new FlowLayout ());
>> 62:         list.setBounds(100, 100, 100, 100);
>> 63:         for(int i=0 ; i < 7 ; i++){
> 
> Suggestion:
> 
>         for(int i = 0 ; i < 7 ; i++){

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781183071
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781184555
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781184867
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781185059
PR Review Comment: https://git.openjdk.org/jdk/pull/21253#discussion_r1781185263