RFR: 8317116: Provide layouts for multiple test UI in PassFailJFrame [v4]
Phil Race
prr at openjdk.org
Mon Sep 30 21:49:38 UTC 2024
On Fri, 27 Sep 2024 16:32:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Provides a set of default layouts for manual test using multiple test UI windows.
>>
>> The initial implementation in the demo in #15721 was too complicated. After looking at the simplified version used in #21180, I re-worked the layouts into separate methods.
>>
>> The layout methods are in `WindowLayouts` class next to `PassFailJFrame`. It is not necessary to mention it explicitly in the `@build` jtreg tag.
>>
>> The builder now provides new methods:
>>
>> - `positionTestUIRightRow` positions the test UI windows in a row to the right of the instruction frame. The top of the windows is aligned to that of the instruction frame.
>> - `positionTestUIRightColumn` positions the test UI windows in a column to the right of the instruction frame. The top of the first window is aligned to that of the instruction frame.
>> - `positionTestUIRightColumnCentered` positions the test UI windows in a column to the right of the instruction frame centering the stack of the windows.
>> - `positionTestUIBottomRow` positions the test UI windows in a row to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>> - `positionTestUIBottomRowCentered` positions the test UI windows in a row to the bottom of the instruction frame centering the row of the windows.
>> - `positionTestUIBottomColumn` positions the test UI windows in a column to the bottom of the instruction frame. The left of the first window is aligned to that of the instruction frame.
>>
>> If required, the test developer can provide a custom implementation.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge master
> - Remove extra line layoutRow
> - bottomOneRowCentered: layoutColumn -> layoutRow
> - Add missing parentheses for vertical positioning
> - 8317116: Provide layouts for multiple test UI in PassFailJFrame
nice
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21207#pullrequestreview-2338631084
More information about the client-libs-dev
mailing list