RFR: 8288471: java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI

[Damon Nguyen]

On Fri, 28 Mar 2025 11:09:03 GMT, Manukumar V S <mvs at openjdk.org> wrote:

> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently in CI, especially in MacOS machines.
> Also the frame created in this test is not disposed which may interfere with other tests.
> 
> Fix:
> Some stabilisations added and the frame is disposed properly.
> 
> Testing:
> Tested 100 times per platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS.

test/jdk/java/awt/ScrollPane/bug8077409Test.java line 102:

> 100:           }  else if (keyEvent.getKeyCode() == KeyEvent.VK_2) {
> 101:             obj.repaint();
> 102:          } else if (keyEvent.getKeyCode() == KeyEvent.VK_DOWN) {

These look like non-standard indents/spacing as well. Typically 4 spaces are used.

test/jdk/java/awt/ScrollPane/bug8077409Test.java line 129:

> 127:       robot.waitForIdle();
> 128:       robot.delay(300);
> 129:       if(y != obj.pane.getComponent(0).getLocation().y){

Since it was mentioned in a separate review comment, this would also need some edits.
Suggestion:

      if (y != obj.pane.getComponent(0).getLocation().y) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2022048145
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2022048582