RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v2]
Renjith Kannath Pariyangad
rkannathpari at openjdk.org
Tue Apr 1 11:33:55 UTC 2025
On Fri, 28 Mar 2025 16:28:48 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated copyright year
>
> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 223:
>
>> 221: ImageIO.write(image,"png", new File("Screenshot.png"));
>> 222: } catch (IOException e) {
>> 223: e.printStackTrace();
>
> I'm not sure it's the best idea to hide the error and just print it into stdout. Wouldn't it be better to just throw the error, what do you think?
I don't think its a good idea
1. IOException was not the original intention of this test and its only for additional information
2. If we throw the error we will miss the actual exception, potentially that was the next instruction.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24286#discussion_r2022672989
More information about the client-libs-dev
mailing list