RFR: 8353320: Open source more Swing text tests [v2]

[Phil Race]

On Wed, 2 Apr 2025 16:15:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8353320
>
> test/jdk/javax/swing/text/html/FrameView/4463014/bug4463014.java line 47:
> 
>> 45:     static JFrame createUI() {
>> 46: 
>> 47:         JFrame frame = new JFrame("bug4463014");
> 
> Suggestion:
> 
>     """;
> 
>     static JFrame createUI() {
>         JFrame frame = new JFrame("bug4463014");
> 
> Add a blank line to separate the instructions from code.
> 
> A blank line as the first line of a method is redundant.

ok

> test/jdk/javax/swing/text/html/FrameView/4463014/frameset.html line 11:
> 
>> 9:   <FRAME name="main" SRC="frame2.html">
>> 10:  </FRAMESET>
>> 11: </HTML>
> 
> A blank line in the end of file?

Not that I can see .. even doing a binary dump, and I didn't edit this file at all, I just moved it from closed to open.

> test/jdk/javax/swing/text/html/HTMLEditorKit/bug4102068.java line 26:
> 
>> 24: /* @test
>> 25:  * @bug 4102068
>> 26:  * @summary Tests that JTextPane with HTMLEditorKit handles the HEAD tag properly
> 
> The summary doesn't match the instructions.
> 
> The test verifies if the cursor for text and for hyperlinks can be changed, doesn't it?

fixed

> test/jdk/javax/swing/text/html/HTMLEditorKit/bug4198022.java line 26:
> 
>> 24: /* @test
>> 25:  * @bug 4198022
>> 26:  * @summary Tests that JTextPane with HTMLEditorKit handles the HEAD tag properly
> 
> The summary doesn't match the instructions.

fixed

> test/jdk/javax/swing/text/html/HTMLEditorKit/bug4245401.java line 61:
> 
>> 59:             kit.read(new StringReader(text), doc, 0);
>> 60:         } catch (Exception e) {
>> 61:         }
> 
> If an exception occurs, the test should fail; the exception shouldn't be *silently* ignored.

Not something I added but I can re-throw as RTE. I verified that will cause the test to fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24365#discussion_r2025432528
PR Review Comment: https://git.openjdk.org/jdk/pull/24365#discussion_r2025440658
PR Review Comment: https://git.openjdk.org/jdk/pull/24365#discussion_r2025446503
PR Review Comment: https://git.openjdk.org/jdk/pull/24365#discussion_r2025451162
PR Review Comment: https://git.openjdk.org/jdk/pull/24365#discussion_r2025457256