RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu Apr 3 11:20:06 UTC 2025
On Fri, 28 Mar 2025 16:34:59 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated copyright year
>
> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 78:
>
>> 76: public class TaskbarPositionTest implements ActionListener {
>> 77:
>> 78: private static JFrame frame;
>
> Nit: I don't think `* @run main TaskbarPositionTest` is needed. But it's fine as it is too, don't have any strong feelings
It may not work without explicit `@run` because the test contains `@build` tags.
`@run` is implied if there are no other commands, such as `@compile` or `@build`, but it's not the case in this test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24286#discussion_r2026779725
More information about the client-libs-dev
mailing list