RFR: 8353138: Screen capture for test TaskbarPositionTest.java, failure case [v4]

[Alexey Ivanov]

On Thu, 3 Apr 2025 14:34:08 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Added screen capture in case of test failure using Robot. 
>> 
>> Please review and let me know your suggestion if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated screen capture function

Looks good to me except for the redundant comment before `saveScreenCapture`.

I'd also move the `saveScreenCapture` method to the very bottom of the test because it's the least important piece of code.

test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 216:

> 214:     }
> 215: 
> 216:     // for debugging purpose, saves screen capture when test fails.

I'm strongly for removing the comment, it adds no value.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24286#pullrequestreview-2740181476
PR Review Comment: https://git.openjdk.org/jdk/pull/24286#discussion_r2027176409