RFR: 8353002: Remove unnecessary Windows version check in WTaskbarPeer

Alexey Ivanov aivanov at openjdk.org
Mon Apr 7 19:41:20 UTC 2025


On Mon, 7 Apr 2025 14:40:38 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:

>> src/java.desktop/windows/classes/sun/awt/windows/WTaskbarPeer.java line 46:
>> 
>>> 44:     private static synchronized void init() {
>>> 45:         if (!initExecuted) {
>>> 46:             supported = ShellFolder.invoke(() -> nativeInit());
>> 
>> I wonder what will happen if I start `java.exe` on a system with Windows Vista which doesn't support these features.
>> 
>> If the native code returns an error, then it's fine.
>> 
>> I ask this question not only out of curiosity but also because it looks like people run Java apps on Windows versions before Windows 10. We had to implement fallback for older versions of Windows in [JDK-8321151](https://bugs.openjdk.org/browse/JDK-8321151).
>
> @aivanov-jdk Are there any additional concerns from your side after the clarifications from Sergey and Phil?

> Interesting, thanks for the link!
> 
> One issue I see with [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) is that it didn't work all the way back to the original Windows 10 release, which conflicts with the [Oracle compatibility matrix](https://www.oracle.com/java/technologies/javase-subscription/documentation.html#sysconfig).

The original release of Windows 10 isn't supported by Microsoft, therefore it's not supported by Oracle.

> But besides that, I'm surprised that a fix was implemented and tested targeting Windows 7 compatibility. Is there a different OpenJDK compatibility matrix that I should be aware of? If not, what were the criteria dictating that Windows 7 compatibility be maintained (at least in 2023)?

Each JDK vendor could have their own compatibility matrix which are different from Oracle.

> But Windows Vista isn't something I care about for JDK 25, although "not crashing" would be nice :-)

Very true, Windows Vista is unlikely to be still in use, its adoption was low even when it was new.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24287#discussion_r2031898268


More information about the client-libs-dev mailing list