RFR: 8352687: Opensource few JInternalFrame and JTextField tests

[Harshitha Onkar]

On Mon, 7 Apr 2025 04:39:05 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few JInternalFrame and JTextField tests are opensourced

test/jdk/javax/swing/JInternalFrame/bug4190516.java line 60:

> 58:         fr.getContentPane().add(jdp);
> 59: 
> 60:         JInternalFrame  jif = new JInternalFrame("Title", true, true, true, true);

Suggestion:

        JInternalFrame jif = new JInternalFrame("Title", true, true, true, true);

test/jdk/javax/swing/JInternalFrame/bug4242045.java line 54:

> 52:         "Iconifiable", "Maximizable", "Closable" under different LookAndFeels.
> 53:         If they appears and disappears correctly then test passes. If any
> 54:         button not appear or disappear as expected or appear with incorrect

Suggestion:

        button does not appear or disappear as expected or appear with incorrect

test/jdk/javax/swing/JTextField/bug4232716.java line 55:

> 53:                 e = new JEditorPane("text/html", html);
> 54:                 e.setEditable(false);
> 55:                 frame.getContentPane().add(e);

Suggestion:

                frame.add(e);

test/jdk/javax/swing/JTextField/bug5027332.java line 51:

> 49:             The caret should be placed slightly off text field borders,
> 50:             so that it can be easily distinguished from the border.
> 51:             Test fails if the caret touches the border.""";

Just a thought: Would it be good to extend this test  to all platforms (getSystemLookAndFeelClassName()) since it verifies if caret does not merge with the text field border?

test/jdk/javax/swing/JTextField/bug5027332.java line 70:

> 68: 
> 69:     private static JFrame createTestUI() {
> 70: 

Extra line can be removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2033672487
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2033676886
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2033681471
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2033700177
PR Review Comment: https://git.openjdk.org/jdk/pull/24474#discussion_r2033682849