RFR: 8353549: Open source events tests batch2

[Harshitha Onkar]

On Tue, 8 Apr 2025 15:07:27 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> few more events tests are open sourced.

test/jdk/java/awt/event/MouseEvent/DragMouseEventTest.java line 67:

> 65: 
> 66: public class DragMouseEventTest {
> 67:     private static ExtendedRobot robot;

This test fails for me on Windows 11 with the following stack trace:


java.lang.RuntimeException: 4096: Mouse drag or release was not received
mouseDraggedReceived false mouseReleasedReceived false
	at DragMouseEventTest.testButtonDrag(DragMouseEventTest.java:260)
	at DragMouseEventTest.testComponent(DragMouseEventTest.java:125)
	at DragMouseEventTest.test(DragMouseEventTest.java:97)
	at DragMouseEventTest.main(DragMouseEventTest.java:74)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)

test/jdk/java/awt/event/MouseEvent/DragMouseEventTest.java line 368:

> 366: 
> 367:             setSize(500, 400);
> 368:             setLocation(200, 200);

It might be better to have the testUI at the center of the screen to prevent any unwanted interactions with screen menu bars.

Suggestion:

           setLocationRelativeTo(null);

test/jdk/java/awt/event/MouseEvent/DragMouseEventTest.java line 438:

> 436:         }
> 437:     }
> 438: }

EOF newline missing

test/jdk/java/awt/event/MouseEvent/MouseRButTest.java line 61:

> 59:             robot.delay(500);
> 60: 
> 61:             Point point = Util.invokeOnEDT(() -> button.getLocationOnScreen());

Received a suggestion on one of my other PRs that awt/regtesthelper/Util can be replaced with swing/regtesthelper/Util.getCenterPoint(button) (makes it easier and it is already called on EDT)

test/jdk/java/awt/event/MouseEvent/MouseRButTest.java line 99:

> 97:         frame.setVisible(true);
> 98:     }
> 99: }

EOF newline missing

test/jdk/java/awt/event/MouseEvent/TitleBarGetsMousePressed.java line 59:

> 57:         frame.setSize(300, 200);
> 58:         frame.addMouseListener(new MouseAdapter() {
> 59:             public void mouseClicked(java.awt.event.MouseEvent ev) {

Can be shortened by adding `import java.awt.MouseEvent`

Suggestion:

            public void mouseClicked(MouseEvent ev) {

test/jdk/java/awt/event/MouseEvent/TitleBarGetsMousePressed.java line 64:

> 62:             }
> 63: 
> 64:             public void mousePressed(java.awt.event.MouseEvent ev) {

same as above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033799795
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033972129
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033975673
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033985607
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033985980
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033992939
PR Review Comment: https://git.openjdk.org/jdk/pull/24516#discussion_r2033993407