RFR: 8353007: Open some JComboBox bugs 2

[Harshitha Onkar]

On Tue, 8 Apr 2025 01:53:23 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Updating and opening some tests

Changes requested by honkar (Reviewer).

test/jdk/javax/swing/JComboBox/bug4185024.java line 37:

> 35:  * @bug 4185024
> 36:  * @summary Tests that Heavyweight combo boxes on JDesktop work correctly
> 37:  * @library /open/test/jdk/java/awt/regtesthelpers

Please update lib paths. Applicable for other tests as well.

Suggestion:

 * @library /java/awt/regtesthelpers

test/jdk/javax/swing/JComboBox/bug4201964.java line 36:

> 34:  * @summary Tests that JComboBox's arrow button isn't drawn too wide in Windows Look&Feel
> 35:  * @requires (os.family == "windows")
> 36:  * @library /open/test/jdk/java/awt/regtesthelpers /open/test/lib

Suggestion:

 * @library /java/awt/regtesthelpers  test/lib

test/jdk/javax/swing/JComboBox/bug4201964.java line 57:

> 55:         PassFailJFrame.builder()
> 56:                 .instructions(INSTRUCTIONS)
> 57:                 .rows(50)

50 rows might be more for this test.

test/jdk/javax/swing/JComboBox/bug4201964.java line 79:

> 77:         frame.add(panel);
> 78:         frame.setLocationRelativeTo(null);
> 79:         frame.pack();

frame.setSize() instead of pack() ?

test/jdk/javax/swing/JComboBox/bug4249732.java line 56:

> 54:         PassFailJFrame.builder()
> 55:                 .instructions(INSTRUCTIONS)
> 56:                 .rows(50)

Same here 50 rows might be bit more than required. Since it cause the instruction window to extend down the whole screen.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24496#pullrequestreview-2751652252
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2034193195
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2034194468
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2034194857
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2034195418
PR Review Comment: https://git.openjdk.org/jdk/pull/24496#discussion_r2034197028