RFR: 8351110: ImageIO.write for JPEG can write corrupt JPEG for certain thumbnail dimensions [v4]

[Jeremy Wood]

On Wed, 9 Apr 2025 15:01:38 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Thank you for pointing out the `new Error` oversight.
>> 
>>> The WriteJPEGThumbnailTest.jtr file says, the test failed
>> 
>> That output is exactly what I would expect to see before this PR. Is it possible you ran the test without invoking `make`?
>> 
>> When I run this test my jtr file includes:
>> 
>> 
>> ----------messages:(8/301)----------
>> command: main WriteJPEGThumbnailTest
>> reason: User specified action: run main WriteJPEGThumbnailTest 
>> started: Sat Apr 05 01:24:48 EDT 2025
>> Mode: othervm
>> Additional options from @modules: --add-modules java.desktop
>> Process id: 63942
>> finished: Sat Apr 05 01:24:49 EDT 2025
>> elapsed time (seconds): 1.248
>> ----------configuration:(3/40)----------
>> Boot Layer
>>   add modules: java.desktop
>> 
>> ----------System.out:(4/84)----------
>> Testing thumbnail 100x218...
>> 	Test passed
>> Testing thumbnail 100x219...
>> 	Test passed
>> ----------System.err:(1/15)----------
>> STATUS:Passed.
>> ----------rerun:(24/1876)*----------
>> 
>> 
>> (I tested both before and after the revisions of the last 24 hrs.)
>
>> Thank you for pointing out the `new Error` oversight.
>> 
>> > The WriteJPEGThumbnailTest.jtr file says, the test failed
>> 
>> That output is exactly what I would expect to see before this PR. Is it possible you ran the test without invoking `make`?
> 
> I pointed out that missing `new Error` made the test pass even though it failed.
> 
> I didn't build JDK with the fix.
> 
> [Phil said](https://github.com/openjdk/jdk/pull/23920#pullrequestreview-2743803137), “Testing looks good,” and I didn't run the full client test suite.

Ah, OK. So is there any outstanding question in this thread?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23920#discussion_r2035846079