Removing obsolete Aqua code

Jeremy Wood mickleness at gmail.com
Fri Apr 11 16:58:24 UTC 2025


in https://bugs.openjdk.org/browse/JDK-8344697 I pointed out that in 
Mac's Aqua L&F: we’re using AncestorListeners to help repaint JRootPane 
default buttons.

Over a decade ago this logic was needed to emulate the native Aqua 
experience, but since around 2016 the default button in Aqua does NOT 
continually pulse.

I’d like to remove this code, but I’m not sure how to proceed.

Originally I planned to make a PR for 8344697 
<https://bugs.openjdk.org/browse/JDK-8344697> that removes the unused 
code. But after rebalancing the AWTEventMulticaster (in 
https://bugs.openjdk.org/browse/JDK-8342782 ), the performance problems 
observed in 8344697 <https://bugs.openjdk.org/browse/JDK-8344697> do not 
reproduce.

Should I:
A. File a new ticket just to remove the obsolete code?
B. Go ahead and name this new PR after 8344697 
<https://bugs.openjdk.org/browse/JDK-8344697> , even though that’s a 
little misleading now?
C. Don’t pursue this, because without a concrete problem / business case 
the OpenJDK community shouldn’t focus on this tech debt.

Thoughts?

Regards,
  - Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20250411/58e21750/attachment.htm>


More information about the client-libs-dev mailing list