RFR: 8354214: Open source Swing tests Batch 2

Harshitha Onkar honkar at openjdk.org
Fri Apr 11 17:24:27 UTC 2025


On Fri, 11 Apr 2025 05:52:47 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> Few swing JList tests are open sourced.

LGTM apart from minor suggestion added inline

test/jdk/javax/swing/JList/bug4193267.java line 63:

> 61:             .instructions(INSTRUCTIONS)
> 62:             .columns(35)
> 63:             .testUI(initialize())

PassFailJFrame's  ` .positionTestUI(WindowLayouts::rightOneRow)` can be used to position multiple windows side by side.

test/jdk/javax/swing/JList/bug4618767.java line 51:

> 49:     private static JList list;
> 50:     private static boolean menuSelected;
> 51:     private static boolean failed;

Since it is accessed on two different threads.

Suggestion:

    private static volatile boolean failed;

test/jdk/javax/swing/JList/bug4618767.java line 107:

> 105:         }
> 106:         Robot robot = new Robot();
> 107:         robot.setAutoDelay(500);

Can we reduce autoDelay to a smaller number?

-------------

Marked as reviewed by honkar (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24588#pullrequestreview-2761018704
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2039960865
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2039967376
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2039968810


More information about the client-libs-dev mailing list