RFR: 8352908: Open source several swing tests batch1
Harshitha Onkar
honkar at openjdk.org
Fri Apr 11 18:15:36 UTC 2025
On Wed, 9 Apr 2025 21:47:07 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> Open-sourcing and standardizing several tests (JSplitPane JApplet JToolBar)
LGTM apart from the suggestion to use `.setPreferredSize()` instead of `.setSize()` for JSplitPane test
test/jdk/javax/swing/JSplitPane/bug4749792.java line 53:
> 51: JPanel right = new JPanel();
> 52: left.setSize(200, 200);
> 53: right.setSize(200, 200);
You may want to use preferred size for right and left panes so that the JSplitPane divider is not skewed to the left.
Suggestion:
left.setPreferredSize(new Dimension(200, 200));
right.setPreferredSize(new Dimension(200, 200));
test/jdk/javax/swing/JSplitPane/bug4749792.java line 58:
> 56:
> 57: JPanel south = new JPanel();
> 58: south.setSize(new Dimension(20, 20));
Same with south and east panels - setPreferredSize()
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24559#pullrequestreview-2761178135
PR Review Comment: https://git.openjdk.org/jdk/pull/24559#discussion_r2040060795
PR Review Comment: https://git.openjdk.org/jdk/pull/24559#discussion_r2040062608
More information about the client-libs-dev
mailing list