RFR: 8353483: Open source some JProgressBar tests [v3]

[Phil Race]

On Fri, 11 Apr 2025 20:26:38 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8353483
>
> test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 81:
> 
>> 79:     static JPanel createBarSet(ComponentOrientation o) {
>> 80:         JPanel panel = new JPanel();
>> 81:         panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
> 
> Suggestion:
> 
>         panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));

fixed

> test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 104:
> 
>> 102:                                      ComponentOrientation o) {
>> 103:         JPanel panel = new JPanel();
>> 104:         panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
> 
> Suggestion:
> 
>         panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));

fixed

> test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 132:
> 
>> 130: 
>> 131:             UIManager.setLookAndFeel(save);
>> 132:         } catch(Exception e) {
> 
> Suggestion:
> 
>         } catch (Exception e) {

fixed

> test/jdk/javax/swing/JProgressBar/bug4230391.java line 71:
> 
>> 69:     static JPanel createBarSet() {
>> 70:         JPanel panel = new JPanel();
>> 71:         panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
> 
> Suggestion:
> 
>         panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));

fixed

> test/jdk/javax/swing/JProgressBar/bug4230391.java line 85:
> 
>> 83:     static JPanel createProgressBars(String name, String plaf) {
>> 84:         JPanel panel = new JPanel();
>> 85:         panel.setLayout(new BoxLayout(panel,BoxLayout.X_AXIS));
> 
> Suggestion:
> 
>         panel.setLayout(new BoxLayout(panel, BoxLayout.X_AXIS));

fixed

> test/jdk/javax/swing/JProgressBar/bug4230391.java line 124:
> 
>> 122:         JFrame frame = new JFrame("Progress Bar Insets Test");
>> 123:         Container contentPane = frame.getContentPane();
>> 124:         contentPane.setLayout(new BoxLayout(contentPane,BoxLayout.X_AXIS));
> 
> Suggestion:
> 
>         contentPane.setLayout(new BoxLayout(contentPane, BoxLayout.X_AXIS));

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352480
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352846
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352586
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352760
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352645
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040352709