RFR: 8353655: Clean up and open source KeyEvent related tests (Part 1)
Abhishek Kumar
abhiscxk at openjdk.org
Mon Apr 14 12:50:55 UTC 2025
On Sun, 13 Apr 2025 03:29:37 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
> Clean up and open source three tests related to the KeyEvent mechanics.
test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java line 27:
> 25: * @test
> 26: * @bug 4308606
> 27: * @summary Tests whether the keys on the numeric keyboard work
Suggestion:
* @summary Tests whether the keys on the numeric keyboard work
test/jdk/java/awt/event/KeyEvent/FrenchKeyboard.java line 69:
> 67: .awaitAndCheck();
> 68: }
> 69: }
Blank line after this ?
test/jdk/java/awt/event/KeyEvent/HomeEndKeyTest.java line 109:
> 107: case KeyEvent.KEY_TYPED:
> 108: str = "KEY_TYPED";
> 109: break;
`printKey` is not invoked from `keyTyped` method and this case statement won't be reachable. Can be removed safely.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24609#discussion_r2041936093
PR Review Comment: https://git.openjdk.org/jdk/pull/24609#discussion_r2041935823
PR Review Comment: https://git.openjdk.org/jdk/pull/24609#discussion_r2041941812
More information about the client-libs-dev
mailing list