RFR: 8353592: Open source several scrollbar tests

Alexander Zvegintsev azvegint at openjdk.org
Mon Apr 14 22:09:57 UTC 2025


On Fri, 11 Apr 2025 16:57:34 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Few scroll bar tests are open sourced. Testing looks good.
>
> test/jdk/java/awt/Scrollbar/ListScrollbarTest.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 4029465
>> 27:  * @summary Win95 Multiselect List doesn't display scrollbar
> 
> Suggestion:
> 
>  * @summary Win Multiselect List doesn't display scrollbar

I prefer to keep the original issue title.

> test/jdk/java/awt/Scrollbar/ListScrollbarTest.java line 93:
> 
>> 91:     private static void scrollbarCheck(Point point, boolean isScrollbarExpected) {
>> 92:         Color pixelColor = robot.getPixelColor(point.x, point.y);
>> 93:         boolean areColorsSimilar = areColorsSimilar(BG_COLOR, pixelColor, 5);
> 
> Mino : tolerance can be declared as static final var

Let's keep it local as it is only used once.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24590#discussion_r2043004754
PR Review Comment: https://git.openjdk.org/jdk/pull/24590#discussion_r2043015632


More information about the client-libs-dev mailing list