RFR: 8354163: Open source Swing tests Batch 1
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Apr 15 07:33:56 UTC 2025
On Tue, 15 Apr 2025 07:09:51 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
> Few Swing AbstractButton, JList and JMenu tests are open sourced.
test/jdk/javax/swing/AbstractButton/bug4133768.java line 41:
> 39: import javax.swing.JToggleButton;
> 40: import javax.swing.SwingUtilities;
> 41: import java.awt.Color;
nitpicking.. awt imports should be before swing.
test/jdk/javax/swing/AbstractButton/bug4133768.java line 54:
> 52: private static AbstractButton[] buttons;
> 53: private static Point buttonLocation;
> 54: private static int buttonWidth, buttonHeight;
different line declaration needed..
test/jdk/javax/swing/AbstractButton/bug4391622.java line 32:
> 30: import javax.swing.JToolBar;
> 31: import javax.swing.SwingUtilities;
> 32: import java.awt.Color;
same
test/jdk/javax/swing/AbstractButton/bug4391622.java line 54:
> 52: private static JFrame f;
> 53: private static Point buttonLocation;
> 54: private static int buttonWidth, buttonHeight;
different line
test/jdk/javax/swing/JList/bug4251306.java line 37:
> 35: import javax.swing.SwingUtilities;
> 36: import java.awt.Robot;
> 37: import java.awt.event.FocusAdapter;
same
test/jdk/javax/swing/JMenu/bug4624845.java line 56:
> 54: private static int subMenuHeight;
> 55: private static int menuItemWidth;
> 56: private static int menuItemHeight;
should be volatile
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043841369
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043842296
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043846784
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043847039
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043848118
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043850693
More information about the client-libs-dev
mailing list