RFR: 8354163: Open source Swing tests Batch 1 [v2]
Jayathirth D V
jdv at openjdk.org
Tue Apr 15 08:03:16 UTC 2025
On Tue, 15 Apr 2025 07:26:44 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update after review comments
>
> test/jdk/javax/swing/AbstractButton/bug4133768.java line 41:
>
>> 39: import javax.swing.JToggleButton;
>> 40: import javax.swing.SwingUtilities;
>> 41: import java.awt.Color;
>
> nitpicking.. awt imports should be before swing.
Updated.
> test/jdk/javax/swing/AbstractButton/bug4391622.java line 32:
>
>> 30: import javax.swing.JToolBar;
>> 31: import javax.swing.SwingUtilities;
>> 32: import java.awt.Color;
>
> same
Updated.
> test/jdk/javax/swing/JList/bug4251306.java line 37:
>
>> 35: import javax.swing.SwingUtilities;
>> 36: import java.awt.Robot;
>> 37: import java.awt.event.FocusAdapter;
>
> same
Updated.
> test/jdk/javax/swing/JMenu/bug4624845.java line 56:
>
>> 54: private static int subMenuHeight;
>> 55: private static int menuItemWidth;
>> 56: private static int menuItemHeight;
>
> should be volatile
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043870949
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043884229
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043887001
PR Review Comment: https://git.openjdk.org/jdk/pull/24650#discussion_r2043892430
More information about the client-libs-dev
mailing list