RFR: JDK-8353319 : Open source Swing tests - Set 3 [v2]

Harshitha Onkar honkar at openjdk.org
Tue Apr 15 17:20:17 UTC 2025


On Tue, 15 Apr 2025 04:22:15 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - review update
>>  - review update
>
> test/jdk/javax/swing/JRootPane/bug4614623.java line 62:
> 
>> 60:                 .instructions(INSTRUCTIONS)
>> 61:                 .columns(62)
>> 62:                 .rows(12)
> 
> Column of 35 looks much better than 62.
> You can remove setting up rows explicitly.

The current setting looks good on Windows LAF (monospaced font in instructions window)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24639#discussion_r2045107486


More information about the client-libs-dev mailing list