RFR: 8354493: Opensource Several MultiScreen and Insets related tests [v2]
Hendrik Schick
duke at openjdk.org
Tue Apr 15 20:21:55 UTC 2025
On Tue, 15 Apr 2025 16:03:55 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> Several multi screen related Applet tests are converted to manual and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Limit to 80 cols
test/jdk/java/awt/Multiscreen/DialogTest.java line 193:
> 191: public Dialog createDialog() {
> 192: GraphicsConfiguration gc = gds[num].getDefaultConfiguration();
> 193: String title = toString();
unused, use variable instead of toString() afterwards?
test/jdk/java/awt/Multiscreen/DialogTest.java line 210:
> 208: }
> 209: } else {
> 210: if (frameOwned) {
this code part is in 'if' and 'else' path, can be done before.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24654#discussion_r2045407427
PR Review Comment: https://git.openjdk.org/jdk/pull/24654#discussion_r2045409738
More information about the client-libs-dev
mailing list