RFR: 8354451: Open source some more Swing popup menu tests [v2]

[Phil Race]

On Tue, 15 Apr 2025 11:10:19 GMT, Hendrik Schick <duke at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8354451
>
> test/jdk/javax/swing/JPopupMenu/bug4212464.java line 125:
> 
>> 123:     public void actionPerformed(ActionEvent e) {
>> 124:         String str = e.getActionCommand();
>> 125:         if(str.equals(metalClassName) || str.equals(motifClassName)) {
> 
> Suggestion:
> 
>         if (str.equals(metalClassName) || str.equals(motifClassName)) {

updated

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 125:
> 
>> 123:         // CTRL-down will show the popup.
>> 124:         panel.getInputMap().put(KeyStroke.getKeyStroke(
>> 125:                    KeyEvent.VK_DOWN,InputEvent.CTRL_MASK),"OPEN_POPUP");
> 
> Suggestion:
> 
>                    KeyEvent.VK_DOWN,InputEvent.CTRL_MASK), "OPEN_POPUP");

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 158:
> 
>> 156:     }
>> 157: 
>> 158:     static class PopupHandler extends AbstractAction{
> 
> Suggestion:
> 
>     static class PopupHandler extends AbstractAction {

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 159:
> 
>> 157: 
>> 158:     static class PopupHandler extends AbstractAction{
>> 159:         public void actionPerformed(ActionEvent e){
> 
> Suggestion:
> 
>         public void actionPerformed(ActionEvent e) {

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 160:
> 
>> 158:     static class PopupHandler extends AbstractAction{
>> 159:         public void actionPerformed(ActionEvent e){
>> 160:             if(!popupMenu.isVisible())
> 
> Suggestion:
> 
>             if (!popupMenu.isVisible())

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 161:
> 
>> 159:         public void actionPerformed(ActionEvent e){
>> 160:             if(!popupMenu.isVisible())
>> 161:                 popupMenu.show((Component)e.getSource(),40,40);
> 
> Suggestion:
> 
>                 popupMenu.show((Component) e.getSource(), 40, 40);

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 207:
> 
>> 205: 
>> 206:         menubar.add(menu);
>> 207:         for(int i = 0; i < 10; i ++) {
> 
> Suggestion:
> 
>         for (int i = 0; i < 10; i ++) {

done

> test/jdk/javax/swing/JPopupMenu/bug4234793.java line 241:
> 
>> 239:     // PopupMenuListener methods.
>> 240: 
>> 241:     public void popupMenuWillBecomeVisible(PopupMenuEvent e)  {
> 
> Suggestion:
> 
>     public void popupMenuWillBecomeVisible(PopupMenuEvent e) {

done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045632986
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045642697
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045641614
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045641977
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045641078
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045641750
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045639391
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2045639103