RFR: 8354789: Unnecessary null check in sun.awt.windows.WToolkit.getFontPeer [v3]

Andrey Turbanov aturbanov at openjdk.org
Wed Apr 16 13:43:42 UTC 2025


> There is redundant `null` comparison in `sun.awt.windows.WToolkit.getFontPeer`
> Local variable `retval` can't be null after new object assignment.
> https://github.com/openjdk/jdk/blob/24de9dee80738fe6ab1fc726b071546c85bbf79a/src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java#L604-L605

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  add empty line

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/23150/files
  - new: https://git.openjdk.org/jdk/pull/23150/files/ce662e8c..2003d375

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=23150&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23150&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/23150.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23150/head:pull/23150

PR: https://git.openjdk.org/jdk/pull/23150


More information about the client-libs-dev mailing list