RFR: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI
Harshitha Onkar
honkar at openjdk.org
Wed Apr 16 17:02:52 UTC 2025
On Wed, 16 Apr 2025 16:46:02 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> Test has a check for a red-ish color, but the range for the green and the blue values were too loose. A light enough grey would still pass (ex: 200, 190, 190). Reduced these from 200 to 80. Checked the color 200, 80, 80 on an rgb color wheel to decide that this color was red enough as the beginning to a passing rgb value.
It is better to test it at uiScale of 1 especially on windows to avoid fractional pixels side effects with `robot.getPixelColor` although this might not be a problem on CI.
` * @run main/othervm -Dsun.java2d.uiScale=1 bug4952462`
Can we change the line where the current theme is queried from AppContext to setting it explicitly ?
` MetalTheme theme = (MetalTheme) AppContext.getAppContext().get("currentMetalTheme");`
to
MetalLookAndFeel.setCurrentTheme(new OceanTheme());
UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24693#issuecomment-2810182036
More information about the client-libs-dev
mailing list