RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v3]

[Alexander Zvegintsev]

On Tue, 8 Apr 2025 22:45:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open-sourced the following Swing tests:
>> 
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review update

test/jdk/javax/swing/JFileChooser/bug4943900.java line 43:

> 41:     private static final String INSTRUCTIONS = """
> 42:         1. Click "Show FileChooser" button below, FileChooser dialog must
> 43:            appear.

I do not see the "Show FileChooser" button, the file chooser showed automatically.

However, it is shown in an unobvious way (code-wise), via the `frame.add(fc);` call (and later the `setVisible(true)` call on the JFrame shows it).

Is this intentional?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2048060182