RFR: 8354365: Opensource few Modal and Full Screen related tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Apr 17 06:31:04 UTC 2025


On Wed, 16 Apr 2025 13:49:49 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/java/awt/FullScreen/NonfocusableFrameFullScreenTest.java line 128:
> 
>> 126:                     frame.setAlwaysOnTop(true);
>> 127:                 }
>> 128:                 frame.validate();
> 
> Is `frame.validate()` required?

Yes, it is required to for the re-layout of test UI. Although I have remove `frame.pack()` and increased the frame width initially. Otherwise, when the button text is `Set Not Always On Top`, it is not able to have complete text.

> test/jdk/java/awt/Modal/NativeDialogToFrontBackTest.java line 115:
> 
>> 113:         control.setSize(200, 200);
>> 114:         blocked.setVisible(true);
>> 115:         return control;
> 
> Can u send the Frame list to PassFailJFrame and placement also can be handled their.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048319326
PR Review Comment: https://git.openjdk.org/jdk/pull/24685#discussion_r2048319404


More information about the client-libs-dev mailing list